Google Git
Sign in
chromium / chromium / src / b2b6dac92cfaeefba058c69b56a99d0264a6870c
commitb2b6dac92cfaeefba058c69b56a99d0264a6870c[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Thu Jan 25 16:46:13 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jan 25 16:46:13 2018
tree91bd9bc6cec6f21ac04c80c481f6242daf4b2977
parent0e36394f7ff24ffcbc89c4710be8602bd7b2f965 [diff]
[LayoutNG] Fix crash in ResolveHeight

ResolveWidth and ResolvedHeight expects border-box of content size,
but ComputeFullAbsoluteWithChildBlockSize gives content-box and
causes DCHECK failures when the size is less than border+padding.

This patch fixes it to pass border-box instead.

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia7bd0d89e35cf156dae78b59fe069d7d56e1539c
Reviewed-on: https://chromium-review.googlesource.com/886042
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531918}
2 files changed
tree: 91bd9bc6cec6f21ac04c80c481f6242daf4b2977
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .