| commit | b2f0a14bd81bf2af75f7f067415fb1f6bcd2a4da | [log] [tgz] |
|---|---|---|
| author | Andrii Shyshkalov <tandrii@chromium.org> | Tue Dec 04 01:52:29 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 04 01:52:29 2018 |
| tree | 164898288b11dce628be9fe934b9d666ef676ac3 | |
| parent | 82961e227f1296850b33b2fa5834337b5c5a0304 [diff] |
run_presubmit: avoid doing redundant gerrit call. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/299268 There are two steps, both querying Gerrit change details: (1) gerrit get_patch_destination_branch (2) gerrit fetch current CL info Each maintains its own cache, however (1) only caches branches, while (2) caches more data (inside api.trysrever recipe module, however). So, this CL changes this recipe to rely entirely on api.tryserver, saving ~0.5s in every presubmit job :) The intended change, however, is only visible in expectation diff of v8_with_cache*.json because only these test cases use named cache. R=jchinlee Change-Id: I591c6b0bf2c0dc2ecacc4c11045c65dbcc0b5edd Reviewed-on: https://chromium-review.googlesource.com/c/1359892 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Hi build contributor! If you do any change in scripts/master/ or touching any master's html/ directories, you must restart master.chromium.fyi first and ensure that it still works before restarting other masters.
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.