Google Git
Sign in
chromium / chromium / src / b2f553ded0e6e4b194910cf33247c7e81e1f06b2
commitb2f553ded0e6e4b194910cf33247c7e81e1f06b2[log] [tgz]
authorKouhei Ueno <kouhei@chromium.org>Wed Oct 11 07:03:59 2017
committerCommit Bot <commit-bot@chromium.org>Wed Oct 11 07:03:59 2017
tree7c39920e76925fa35b606733e6e932662abe2c48
parent47e4fc53e6d68c0a788fcc26de598b9e3848033f [diff]
[ES6 modules] update run-a-module-script algorithm and fix import() error crash

This CL updates ModuleImplBase::ExecuteModule to match the latest spec text.
The change also fix crash when dynamic import() is attempt on module tree w/ instantiation error.

Test: external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-error.html
Bug: 763597
Change-Id: Icae37257492d3b2a0885fd571ac745f9de49cc6e
Reviewed-on: https://chromium-review.googlesource.com/711634
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507916}
3 files changed
tree: 7c39920e76925fa35b606733e6e932662abe2c48
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .