commit | b2fa8274b92136d9dd2d347b6e33b4e56bfe21f7 | [log] [tgz] |
---|---|---|
author | aberent <aberent@chromium.org> | Thu Jul 13 10:18:13 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jul 13 10:18:13 2017 |
tree | fcaeee50ec974a31d9d20679f22d7c44df96d137 | |
parent | 6430f5dc23868995c86cfbb3829978e7cb34bf32 [diff] |
Revert of Fixes redirects to external apps when navigating from PWA. (patchset #10 id:300001 of https://codereview.chromium.org/2969143002/ ) Reason for revert: Still failing on Marshmallow 64 bit Tester. See, for example https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/13798 BUG=741568 Original issue's description: > Fixes the redirect to external apps when navigating from PWA. > > This is done with avoiding explicit chrome package name (using > component name instead) and using > EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent. > > With this patch the redirect works, however it takes a long time for CCT to > consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect > in ChromeTabbedActivity is almost instantaneous. Result is that > for _blank links CCT shows up briefly before redirecting to an external app. > In a follow up it should be investigated why it is the case and if it cannot > be improved, we might need to bypass CCT in such case, which would diverge > from existing navigation paths for _blank links in Clank. > > BUG=740402 > > Review-Url: https://codereview.chromium.org/2969143002 > Cr-Original-Commit-Position: refs/heads/master@{#485831} > Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e > Review-Url: https://codereview.chromium.org/2969143002 > Cr-Commit-Position: refs/heads/master@{#486275} > Committed: https://chromium.googlesource.com/chromium/src/+/4dbcecfb630ac1a2dba1910f0e429b82bf3a0b5f TBR=dominickn@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,piotrs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=740402 Review-Url: https://codereview.chromium.org/2977023002 Cr-Commit-Position: refs/heads/master@{#486333}