commit | b350ff3bbe1726df9e62911a9b825184fd3457c6 | [log] [tgz] |
---|---|---|
author | Congbin Guo <guocb@chromium.org> | Tue Apr 06 23:55:18 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 06 23:55:18 2021 |
tree | 8358b09051a229169b74258fba8749d0b5b184be | |
parent | da77f51f650bfbac7229647057c8e2717d46dcc7 [diff] |
caching-backend: allow customization on interface keepalived listens on We don't need this feature in standard k8s since all nodes are configured with bond0. This feature is only useful when bond0 is missing and we cannot wait for a day for lab team to create it. BUG=None TEST=Ran locally to ensure the conf generated looks good. Change-Id: Ie675c3eb95c895b9e1411b2dea474221ffdb7fc2 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2808705 Commit-Queue: Congbin Guo <guocb@chromium.org> Auto-Submit: Congbin Guo <guocb@chromium.org> Reviewed-by: Sanika Kulkarni <sanikak@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Cr-Commit-Position: refs/heads/master@{#39959}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.