Google Git
Sign in
chromium / chromium / src / b43863ad9ea99cc432eb95f99c15375bd73bee5e
commitb43863ad9ea99cc432eb95f99c15375bd73bee5e[log] [tgz]
authorarthursonzogni <arthursonzogni@chromium.org>Wed Aug 30 15:53:20 2017
committerCommit Bot <commit-bot@chromium.org>Wed Aug 30 15:53:20 2017
tree436c1e3888335e4209e406f8eaec0434405fc9cf
parent0f448170cbace67a69bfecedaa4efd99708b0d4d [diff]
PlzNavigate: Make BlockLegacySubresources work.

Chrome blocks 'ftp:' subresource request inside 'http'/'https' pages.
See https://crbug.com/435547.

It was broken with PlzNavigate (--enable-browser-side-navigation) when
the subresource is an iframe. The page was blocked, but only after the
request had been sent to the server.
This CL makes chrome block requests before they are submitted.

Additionnally, it removes the
--enable-blink-feature=BlockLegacySubresources switch. It should be
removed for M60 and this patch will land for M62.

Test: NavigationHandleImplBrowserTest.BlockLegacySubresources
Bug: 757809,435547
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ia85417af453b2e0532b0b7c0f381fa8a2f8e6e8a
Reviewed-on: https://chromium-review.googlesource.com/625942
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498476}
6 files changed
tree: 436c1e3888335e4209e406f8eaec0434405fc9cf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .