commit | b4bbf936a543619f153aaf5cef64666c12ef0250 | [log] [tgz] |
---|---|---|
author | Ben Pastene <bpastene@chromium.org> | Tue Aug 11 18:33:20 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 11 18:33:20 2020 |
tree | 525d73f955fbe0fef542e1cd86edd5705cae3d8b | |
parent | 048f05489b0cd7e017adf8671f45267e39f4798d [diff] |
Revert "Switch to passing command lines via an isolated file." This reverts commit 048f05489b0cd7e017adf8671f45267e39f4798d. Reason for revert: assert self._server AssertionErrors eg: https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20dEQP%20Builder/64940 Original change's description: > Switch to passing command lines via an isolated file. > > It turns out that passing command lines via builder properties > causes the command line that kitchen uses to run a chromium recipe to > exceed 32k (the max) on Windows. > > So, this CL switches to passing command lines from builder to > tester via a file uploaded and downloaded from the isolate server; > this should be quite robust. > > [ This is option 2B from > https://docs.google.com/document/d/1UA-3h2Mmqr3BqfEfLFubveFJIk_52T9sBFgC7MShPJ4/edit?usp=sharing ]. > > Bug: 1108005 > Change-Id: I4e823ff3d6f4f73d0af643246b641d75f79c69ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2347247 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> TBR=dpranke@google.com,martiniss@chromium.org,tikuta@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I400f23b674bc6a4ef2f32ae81f30a1c26badcfac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108005, 1115200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2349668 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format
) to autoformat new code.