commit | b54920b5ce0b28a83cf343b94d78c672d12a2645 | [log] [tgz] |
---|---|---|
author | Wez <wez@chromium.org> | Fri Nov 30 20:04:13 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 30 20:04:13 2018 |
tree | 5735f0e012a49f59927b0ef43dfc79db4eae60a5 | |
parent | 1679c39fbc1b0fd6b67331cf69e94f264c5c3de6 [diff] |
Revert "[Reland] Use the SequenceManager in ScopedTaskEnvironment" This reverts commit 49c8774b77a9c530447f805dbb5358092cfa28e1. Reason for revert: CL seems likely cause of a new MainThreadHasPendingTasks() flake observed on the Fuchsia builders (see crbug.com/910645). Original change's description: > [Reland] Use the SequenceManager in ScopedTaskEnvironment > > A reland of https://crrev.com/c/1324391 > > This is necessary because we want content::TestBrowserThreadBundle to > own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment > and you can't have two SequenceManagers on the same thread. > > This patch allows ScopedTaskEnvironment to optionally work with an > externally owned SequenceManager solving the problem. > > This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, > > We now have the ability to mock time on the UI thread. > > TBR=asvitkine@chromium.org,miu@chromium.org,gab@chromium.org,fdoray@chromium.org > > Bug: 863341, 891670, 708584 > Change-Id: Ia4409b885deb9935e6e5b6d99f4598f164d350db > Reviewed-on: https://chromium-review.googlesource.com/c/1354919 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612122} TBR=gab@chromium.org,miu@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910645, 863341, 891670, 708584 Change-Id: I395322743c110f9b1dd424434756f05b2301a45b Reviewed-on: https://chromium-review.googlesource.com/c/1357014 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612741}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .