commit | b643010d742b1323893685b3ded2250d684882c4 | [log] [tgz] |
---|---|---|
author | Jinsuk Kim <jinsukkim@chromium.org> | Sat Dec 08 00:06:02 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Dec 08 00:06:02 2018 |
tree | b25c496a3df30dc42b08520aaf5cdfee98c5a39d | |
parent | 401770722daeea00304d0c06bf3cf57c5ca5b686 [diff] |
Reland "Android: Factor InProductHelp UI out of Tab" again This reverts commit fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277. Reason for revert: Reverted on a false alarm. Landing again. Original change's description: > Revert "Reland "Android: Factor InProductHelp UI out of Tab"" > > This reverts commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/2097 > > https://crbug.com/907602 doesn't seem to be addressed. > > Original change's description: > > Reland "Android: Factor InProductHelp UI out of Tab" > > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple > > of bugs in |ToolbarButtonInProductHelpController|: > > > > 1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and > > always used Profile.getLastUsedProfile() > > 2) |OnDismissListener| was instantiated (and menu got highlight for > > the text bubble) every time |setupAndMaybeShowIPHForFeature| is called, > > even when the method doesn't meet the condition for IPH text bubble > > and has to early out. > > > > The CL got reverted due to numerous regressions . This CL fixes them and > > relands it. > > > > This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302. > > > > Bug: 889682, 907502, 907503, 907770, 907505, 907602 > > Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4 > > Reviewed-on: https://chromium-review.googlesource.com/c/1349142 > > Reviewed-by: Theresa <twellington@chromium.org> > > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614161} > > TBR=twellington@chromium.org,jinsukkim@chromium.org > > Change-Id: Id92d47e6ac65a0b1a50f4ad4cb1c0b9a11189993 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 889682, 907502, 907503, 907770, 907505, 907602 > Reviewed-on: https://chromium-review.googlesource.com/c/1366456 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614501} TBR=twellington@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 889682, 907502, 907503, 907770, 907505, 907602 Change-Id: I1cdb497251b4a1f60f955cc6fd90c2be1eae3e96 Reviewed-on: https://chromium-review.googlesource.com/c/1368844 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#614875}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .