commit | b80701cd410d43d4f513f499e51d3ac248739cd7 | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Tue Jan 08 17:16:59 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 08 17:16:59 2019 |
tree | 2330f6defe989494ca3ca395dc815f097a0ce8fd | |
parent | ebfd63fd9e67bf0c2acb17f9396c018fa512e081 [diff] |
Fix SingleClientDirectorySyncTest on TSan The test was disabled due to a data race related to the global FeatureList instance. The problem was that the test body instantiated a ScopedFeatureList, which overrides the global instance. That gets reset after the test body; however, the feature list might still be queried from the Sync thread after that. In this case, it turned out that setting the feature is simply not required for the test; it passes both with and without the feature. Bug: 915219, 856179 Change-Id: If02b4aa3d3fbd7091038bf47cf8745a95ed8cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/1401043 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#620769}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .