Google Git
Sign in
chromium / chromium / src / b80a747d547adbc6c364808d7596377a458a3533
commitb80a747d547adbc6c364808d7596377a458a3533[log] [tgz]
authorLeonard Grey <lgrey@chromium.org>Mon Jul 23 18:33:29 2018
committerLeonard Grey <lgrey@chromium.org>Mon Jul 23 18:33:29 2018
tree15e266e16900260b20e169872a4dfc8f5ff1538d
parentc5f0036dc0323358c39d481777ec1169d2f4056b [diff]
Views: Don't unnecessarily invalidate layout when setting app menu button margin

Currently, we invalidate the app menu button's layout unconditionally when setting
its margin. Since invalidating layout walks up the view hierarchy, this essentially
keeps ToolbarView's layout dirty all the time.

This change exits early if the new margin is the same as the current margin.

Bug: 858944, 835983
Change-Id: If94d3c7d29cb1476fdb268a8ece35187d0b43f4f
Reviewed-on: https://chromium-review.googlesource.com/1144222
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576873}(cherry picked from commit 02b33c1f9c7145169cfda0caf4b5eb0c50e471b5)
Reviewed-on: https://chromium-review.googlesource.com/1147181
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#20}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
1 file changed
tree: 15e266e16900260b20e169872a4dfc8f5ff1538d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .