commit | b8c6f939973d72b1ff741af5bac6bb5dc80baf89 | [log] [tgz] |
---|---|---|
author | Jared Loucks <jaredloucks@google.com> | Mon Mar 22 15:11:54 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 22 15:11:54 2021 |
tree | dbaa5b3b516a1033bb7bd851648f96d6abb27f0d | |
parent | cd0e1b1150152a2677cf77332d65675f3212d4d2 [diff] |
UFS API: change location of field_behavior proto import The previous import location was causing clashing errors when attempting to import any UFS proto file in combination with buildbucket API proto files which import "google/api/field_behavior.proto". Change-Id: I40edcb1812dcd020eb47cc9c68768a177e9ab1fb Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2773447 Auto-Submit: Jared Loucks <jaredloucks@google.com> Reviewed-by: Otabek Kasimov <otabek@google.com> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Jared Loucks <jaredloucks@google.com> Cr-Commit-Position: refs/heads/master@{#39584}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.