commit | b8cb398e39c16f5bb4d7324253908fdb79b45d20 | [log] [tgz] |
---|---|---|
author | Garrett Beaty <gbeaty@chromium.org> | Sat Nov 07 01:48:56 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Nov 07 01:48:56 2020 |
tree | 8a66beeaa76f87a1e7a7b37b0da228f71c779b6b | |
parent | 2ce93791cd8e8aa07bbafdaae8bdd5aaaa677f5f [diff] |
Revert "Create test-type-specific spec types." This reverts commit 2ce93791cd8e8aa07bbafdaae8bdd5aaaa677f5f. Reason for revert: Breaks builders, for example: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/704394 Original change's description: > Create test-type-specific spec types. > > Having separate spec types for each test allows for a reliable > comparison to be performed between specs created in recipes and specs > created from the source side spec files since the specs implement > equality by virtue of being attrs-based classes and any default logic is > handled in the creation of the specs. > > Bug: 1128746 > Change-Id: I33a193fa612724e85ee9f3803fd71c2f84f7ef44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2518342 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> TBR=martiniss@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,gatong@chromium.org Change-Id: I78562dbd428c47b88229701e7a3c5faedac5eda7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2523926 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.