| commit | ba83000c4236541dc5f78ecdac468dc54dea48e8 | [log] [tgz] |
|---|---|---|
| author | Hiroki Nakagawa <nhiroki@chromium.org> | Thu Sep 24 08:31:47 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 24 08:31:47 2020 |
| tree | 5c55c96dbf7b4b43e79c487e12a82d9336d56b29 | |
| parent | f7a42ad723691235c9a30ff04533872a7d0bc4d5 [diff] |
Revert "Remove --isolated-script-test-perf-output from chromium recipe." This reverts commit 98cb0022b0e4f2c6b05a23b31bfe532ed9924885. Reason for revert: This is a speculative revert. This could fail rendering_representative_perf_tests on mac-rel bot: https://ci.chromium.org/p/chromium/builders/try/mac-rel/486009 The failure started at almost the same time with the CL. Original change's description: > Remove --isolated-script-test-perf-output from chromium recipe. > > As discovered/discussed in crbug.com/1127545, it appears that this > flag is not actually ever used anywhere in the chromium recipes. > > Perf tests *do* produce output, but they don't use this flag to > do so. > > WebRTC tests *do* use this flag, but they set this directly in their > own recipes. > > Bug: 1127545 > Change-Id: I215ad8f698c18e41ca2a87c7043371a9ac73000b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2427305 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> TBR=dpranke@google.com,martiniss@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5098761439414a8d26010ec838b6ea6ca41dd8df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2426074 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.