commit | ba8dc4f259adf48fbddd829d4548ec083daddd35 | [log] [tgz] |
---|---|---|
author | Dan Beam <dbeam@chromium.org> | Fri Jan 18 17:58:53 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 18 17:58:53 2019 |
tree | 11ae8c178b339215c56f3ba512f56bb340dc2184 | |
parent | d9d71d7e9f8ebd301d9a6449adfef44e63a65487 [diff] |
Dark Mode: fix a bunch of wrong colors When I first started working on this project, the spec had a bunch of "GG 500" and "GB 300", which to me meant the Material Design colors. But there's actually a new version of the color palette (GM2) with the same names, which is a bit of a bummer. Even more confusingly, various variables in the code use the same naming scheme as Material Design but for GM2. Ex: --google-grey-100 -> Material Design --google-grey-200 -> GM2 There are -refresh version of colors, which mean the GM2 equivalent. --google-grey-500 -> Material Design --google-grey-refresh-500 -> GM2 This is fairly nuts. Anyways, cuz I'm still mildly hoping WebUI dark mode makes Chrome 73, I grepped for all the places that use [dark] and then looked for possibly wrong colors. Here's the command I used: $ git gs '\[dark\]' -l | xargs egrep -l \ '\-\-google-(green|red|blue|grey|gray|yellow)-[1357]00' And updated the files I found. I also added some new GM2 equivalents (more -refresh colors) and ran third_party/polymer/v1_0/rgbify_hex_vars.py on it to produce the -rgb versions. BUG=883049 R=dpapad@chromium.org Change-Id: Ic1160931d70c84fb4cb700a4047e686a93dfbc09 Reviewed-on: https://chromium-review.googlesource.com/c/1415815 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#624194}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .