Google Git
Sign in
chromium / infra / luci / recipes-py / bae937d72f6b21b53a3218efdb0471861a332c0c
commitbae937d72f6b21b53a3218efdb0471861a332c0c[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Wed May 22 00:52:19 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 22 00:52:19 2019
tree25695beb1c193665d553e2d350a5578ada1010ab
parent46311e5fca95329b511a45b42648ead457b2eea5 [diff]
Check validity of _resolved nodes before accessing them.

Post processing expressions that result in KeyErrors can result in
exceptions producing the check failure information if the expression
resulting in a KeyError is part of a larger expression. Checking the
validity of a _resolved node prevents that.

Change-Id: I617112914a88db6339777b30aad13b6d92b09a61
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1623539
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
2 files changed
tree: 25695beb1c193665d553e2d350a5578ada1010ab
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .vpython
  12. AUTHORS
  13. codereview.settings
  14. CONTRIBUTORS
  15. LICENSE
  16. OWNERS
  17. PRESUBMIT.py
  18. README.md
  19. README.recipes.md
  20. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.