Google Git
Sign in
chromium / chromium / src / bed9cb9d56adac6f50313b0e620a1aa2f0d871ed
commitbed9cb9d56adac6f50313b0e620a1aa2f0d871ed[log] [tgz]
authorManish Jethani <m.jethani@eyeo.com>Sat Oct 28 23:02:07 2017
committerCommit Bot <commit-bot@chromium.org>Sat Oct 28 23:02:07 2017
tree2de37adc13433780b24602ca42fa5851b4371ee2
parent96c9e501b87daaed0351eb752b0665db99833eae [diff]
Support @keyframes rules in user style sheets

Previously @keyframes rules in style sheets injected by extensions were
managed in ScopedStyleResolver along with other author rules. With
crrev.com/c/641294 we started treating these injected style sheets as
user style sheets and moved the management of such rules to StyleEngine.
This patch fixes a regression caused by this change whereby
StyleResolver is no longer able to find @keyframes rules from these
style sheets.

StyleEngine now maintains a map of animation names to their
corresponding @keyframes rules found in user style sheets. If
StyleResolver is unable to find a given @keyframes rule among its author
rules, it looks it up in StyleEngine next.

BUG=632009,776661

Change-Id: I90462a0721cc75da14ee041c1a70736e4df99fb8
Reviewed-on: https://chromium-review.googlesource.com/735263
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512411}
4 files changed
tree: 2de37adc13433780b24602ca42fa5851b4371ee2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .