commit | bef2b64696776bdac2ea14124da97a7e3b2c91da | [log] [tgz] |
---|---|---|
author | Kinuko Yasuda <kinuko@chromium.org> | Thu Jan 24 04:53:33 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 24 04:53:33 2019 |
tree | 5c901f562e0281a5ef28983f082be60475500a0d | |
parent | 9e63550ba4334706ad0f466f14f0593cc819a470 [diff] |
Revert "Remove conditional use of LayerTreeView from RenderWidget." This reverts commit 2ae8e4805cf3528619e05806e836a78d2c740e0b. Reason for revert: some layout tests started to crash on CHECK(closing_) https://test-results.appspot.com/data/layout_results/Mac10_13_Tests/9201/webkit_layout_tests/layout-test-results/results.html external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html external/wpt/url/failure.html Original change's description: > Remove conditional use of LayerTreeView from RenderWidget. > > The LayerTreeView is always present since we always composite > RenderWidgets now (for many years ^_^). > > However, the LayerTreeView *is* removed during shutdown. Most places > will not need to worry about this because OnClose() drops the IPC > channel and most uses of LayerTreeView are in response to other IPCs. > > However a few cases involve calls from Blink which could still be > active in between OnClose() and tearing down the RenderWidget+Blink, > so in these cases early out if |closing_| which represents better > conceptually what we're testing. > > TBR=avi@chromium.org > > Change-Id: Iff9133d9c69b327495f9290afcb471739124018b > Bug: 912193 > Reviewed-on: https://chromium-review.googlesource.com/c/1432132 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625473} TBR=avi@chromium.org,ajwong@chromium.org,danakj@chromium.org Change-Id: Ide47f156f8f5d2af32f7442bb659599356c3f6c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1433379 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .