commit | bf66fa912e09b29740b2deb35a3060863acf9125 | [log] [tgz] |
---|---|---|
author | Yutaka Hirano <yhirano@chromium.org> | Wed Jan 30 01:44:29 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 30 01:44:29 2019 |
tree | 6393bf34052e10ca25aec23a80a1dbc248188ea5 | |
parent | 8d3ca3c0c009ffdca7997824e8025765916a604c [diff] |
Replace FetchContext::Bind with Init FetchContext::Bind and FetchContext::Unbind were introduced to make splitting FetchContext smoother, but their semantics were complex and somewhat conflicting with FetchContext::Detach. Also, we want use GetFetchResourceProperties() in FetchContext after detached, which is not possible with the current implementation because |fetcher_| is cleared when Unbind is called. This CL introduces Init and removes Bind and Unbind. Now ResourceFetcherProperties, not ResourceFetcher, is stored in FetchContext. As ResourceFetcherProperties is safe to be accessed after detached, we don't clear the ResourceFetcherProperties when detached. Also, FetchContext::IsDetached is removed as we can use GetFetchResourceProperties().IsDetached now. Bug: 914739 Change-Id: Ia1a41c0d7f8d8a47288868b5165a3ee08c106de9 Reviewed-on: https://chromium-review.googlesource.com/c/1424103 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#627268}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .