Google Git
Sign in
chromium / chromium / src / c0c7d3c7215b22456d2ff559ccd509ca7b22efd4
commitc0c7d3c7215b22456d2ff559ccd509ca7b22efd4[log] [tgz]
authorDmitry Gozman <dgozman@chromium.org>Mon Dec 10 21:09:20 2018
committerCommit Bot <commit-bot@chromium.org>Mon Dec 10 21:09:20 2018
treece750d90b7e34d444183500621e7584a873e6e3d
parent340b590451023790134cde96d82dfff9f64eb790 [diff]
WebURLLoaderMock: do not call DidReceiveResponse on failures

The real url loader does not notify about response if it failed
before receiving first byte of the body data.

Our current of calling DidReceiveResponse before DidFail without
a single byte of data disagrees with navigation flow, which never
sends a response if failed before receiving the body.

This patch unblocks synchronous navigation commit from
DidReceiveResponse, as opposite to DidReceiveData.

Bug: 855189
Change-Id: I48691bc21a5886d3b24e14b5c1d3e2df6e36bb33
Reviewed-on: https://chromium-review.googlesource.com/c/1368653
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615252}
2 files changed
tree: ce750d90b7e34d444183500621e7584a873e6e3d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .