Google Git
Sign in
chromium / chromium / src / c179dc03b3db05f4a5726649171eb32a7d748f04
commitc179dc03b3db05f4a5726649171eb32a7d748f04[log] [tgz]
authorEhsan Karamad <ekaramad@chromium.org>Sat Dec 15 03:09:29 2018
committerCommit Bot <commit-bot@chromium.org>Sat Dec 15 03:09:29 2018
tree8adc68f97b9fc959f5c2ced2b1abc83682e69118
parent325579e66c6e496f6a3a227164d42e38ea86d538 [diff]
GuestView: No TextInputManager when unattached

 TextInputManager is created lazily the first time GetTextInputManager
is called on WebContents. Given that TextInputManager should only exist
for the outermost WebContents, there is no point in creating it for an
unattach guest WebContents only to clear it after attaching. Also, it
seems incorrect to try to access |text_input_manager_| for an unattached
guest WebContents.

Bug: 609846
Change-Id: I0b60a0a3160909f9d8c0b6a4c099c3f4769af0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1376090
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616934}
1 file changed
tree: 8adc68f97b9fc959f5c2ced2b1abc83682e69118
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .