| commit | c210466b5c2bcb4d94191efa30d5d1a6f7ebbcc8 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Fri Oct 23 19:05:55 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 23 19:05:55 2020 |
| tree | 1cb49074e007d63406721833e46b776f96a6854d | |
| parent | 409188f97be0a541f7b7094e7113014c684926b7 [diff] |
[cipd] Handle empty responses from CIPD
During a recent GCS outage, we saw some `cipd ensure` failures where
CIPD didn't produce any JSON output. Then the recipe would crash with a
`TypeError("argument of type 'NoneType' is not iterable")` trying to
look up the 'error' key in the JSON output. For example:
https://ci.chromium.org/b/8865717012587636816
To avoid this, skip checking for the 'error' key if the JSON output is
falsy and just re-raise the original StepFailure.
Bug: fuchsia:62641
Change-Id: I2bcd9256e5142dae602728a71feea7fba93e4736
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/2495134
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Oliver Newman <olivernewman@google.com>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.