| commit | c236d3b2efe063dc0914e2bebdb4c28cac7fa6c2 | [log] [tgz] |
|---|---|---|
| author | mnissler <mnissler@chromium.org> | Mon Oct 19 08:08:42 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Oct 19 08:09:34 2015 |
| tree | 04f66a5d79f09de365337851e23e4c8d2d56edec | |
| parent | 3d5d4e33ef71fecdafaaa920ad5a1b4fe03d13fb [diff] |
Revert of Implement $Secure- cookie prefix (patchset #16 id:420001 of https://codereview.chromium.org/1393193005/ ) Reason for revert: Broke net_unittests on Android: I 63.275s run_tests_on_device(06b2a92a003bca26) [ RUN ] URLRequestTest.SecureCookiePrefixOnNonsecureOrigin I 63.275s run_tests_on_device(06b2a92a003bca26) [ERROR:spawner_communicator.cc(241)] request failed, status: 3, error: -324 I 63.275s run_tests_on_device(06b2a92a003bca26) ../../net/url_request/url_request_unittest.cc:2737: Failure I 63.276s run_tests_on_device(06b2a92a003bca26) Value of: test_server_https.Start() I 63.276s run_tests_on_device(06b2a92a003bca26) Actual: false I 63.276s run_tests_on_device(06b2a92a003bca26) Expected: true I 63.276s run_tests_on_device(06b2a92a003bca26) [ERROR:spawner_communicator.cc(241)] request failed, status: 3, error: -324 I 63.276s run_tests_on_device(06b2a92a003bca26) [ FAILED ] URLRequestTest.SecureCookiePrefixOnNonsecureOrigin (487 ms) http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/30742 http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/22819 Original issue's description: > Implement $Secure- cookie prefix > > This CL implements the rule that cookies whose names start with > $Secure- can only be set if the Secure attribute is enabled. The > implementation is a runtime-enabled web platform feature for now. > > Intent to Implement: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/IU5t6eLuS2Y/Uq-7Kat9BwAJ > > BUG=541511 > TBR=droger@chromium.org > > Committed: https://crrev.com/467a098174e062d4380eb0ad8f7b2f0b0b7ed5fa > Cr-Commit-Position: refs/heads/master@{#354676} TBR=mkwst@chromium.org,jochen@chromium.org,mmenke@chromium.org,droger@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=541511 Review URL: https://codereview.chromium.org/1409243003 Cr-Commit-Position: refs/heads/master@{#354736}