commit | c27f979330975f58687c67d6dbcf5273e3ef0d0e | [log] [tgz] |
---|---|---|
author | Kevin Chowski <chowski@google.com> | Wed Mar 24 20:00:55 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 24 20:00:55 2021 |
tree | 14971026e1e8a4b4de1e7fc0f303bea0982245db | |
parent | 6629331acf0401ad681a09a536dbc36535bf9b1e [diff] |
Pinpoint cli: infer some flag defaults from `git cl issue`. Added in https://crrev.com/c/2766153, we can use the structured output of that command to guess which gerrit/gitiles host to use, as well as the repository the user cares about. If an error occurs, we silently fall back to the hard-coded default of Chromium. Change-Id: Icce6a508585b10d0893a19d30f06b6382c1d633d Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2783360 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Dean Berris <dberris@chromium.org> Commit-Queue: Kevin Chowski <chowski@google.com> Cr-Commit-Position: refs/heads/master@{#39693}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.