Google Git
Sign in
chromium / chromium / src / c3408668fb2bb8bce5bb6b0dc2a00ec09c1e6419
commitc3408668fb2bb8bce5bb6b0dc2a00ec09c1e6419[log] [tgz]
authorHiroshige Hayashizaki <hiroshige@chromium.org>Fri Jan 11 02:01:51 2019
committerCommit Bot <commit-bot@chromium.org>Fri Jan 11 02:01:51 2019
tree0964896a4718d0a119978b2e5e1110084f7118f9
parentd4a54be4726876307f1cf0e1977b692f049b2b87 [diff]
Do not call EnsureFetcher() in ThreadableLoader for outsideSettings fetch

Currently, ThreadableLoader always calls EnsureFetcher(),
which is not necessary and
would cause assertion failures when switching the worker's URL
because this creates worker's insideSettings ResourceFetcher
(which depends on ExecutionContext and its URL)
at the start of outsideSettings top-level script fetch.

This CL skips such unnecessary EnsureFetcher() calls and thus
avoids the assertion failures.

Bug: 880027, 835717, 861564
Change-Id: I7768b0274bdc47e856df2a4a529d4b223d978c80
Reviewed-on: https://chromium-review.googlesource.com/c/1394643
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621863}
1 file changed
tree: 0964896a4718d0a119978b2e5e1110084f7118f9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .