commit | c368d9b6d129ff6b01d87b3ec840d7779010db7b | [log] [tgz] |
---|---|---|
author | John Chen <johnchen@chromium.org> | Thu Jan 03 19:30:00 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 03 19:30:00 2019 |
tree | 1144845a3d17e3b08c3fcd74a06ce511f18ce3b7 | |
parent | f32d20988573ebbb09b4852ed3e7f516fde50bee [diff] |
Reland "[ChromeDriver] Handle pauses in Perform Actions" This is a reland of 70ffd44758afa0d3d2a7c71adf4d4513190306e4 Original change was reverted due to test flakiness on Mac, caused by: * Pause time often goes above the upper limit of 300 ms, sometime more than double the limit. * Occasionally the first event is missing. The following changes are made to improve test reliability: * Remove the check of an upper limit for the pause time. With the wide range of actual pause time, there appears to be no feasible upper limit to use. * The first significant event is now pointer down instead of key down, to ensure that the target element receives focus. The previous dependence on autofocus attribute appears to be unreliable. * Change mouse button from 1 (middle) to 0 (left), as the middle mouse button triggers paste on some platforms. (It was a typo.) Original change's description: > [ChromeDriver] Handle pauses in Perform Actions > > W3C spec allows the app to specify pauses within Perform Actions command > (https://w3c.github.io/webdriver/#dfn-dispatch-actions). Updating > ChromeDriver to handle these pauses. > > Bug: chromedriver:1897 > Change-Id: I533179f4a9f2216bfacf0f4fdb539c8f898bed07 > Reviewed-on: https://chromium-review.googlesource.com/c/1392281 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619506} Bug: chromedriver:1897 Change-Id: I38122bdc01965345421429b1d2f45374395b0cc7 Reviewed-on: https://chromium-review.googlesource.com/c/1394786 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619717}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .