commit | c43a88e2214e3173568cac5256b57d0f7d22ac15 | [log] [tgz] |
---|---|---|
author | Vadym Doroshenko <dvadym@chromium.org> | Mon Jan 08 13:51:17 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 08 13:52:55 2018 |
tree | 91c6731a30cfd1c4a4d31f2b6ef9f852df505974 | |
parent | 535ce599bbb560914af0b054a20051e37b54d78b [diff] |
Revert "Do not reveal username value till user gesture." This reverts commit f69d6349c5e6be22df72d21b1f9f883ac9350870. Reason for revert: this CL breaks many tests on build bots, eg. https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20Tests%20(sandboxed)/42554 and https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel/builds/4123 Original change's description: > Do not reveal username value till user gesture. > > Passwords are not available for a page till user gesture. > But for usernames it was not implemented. This patch implements > this: use SetSuggestedValue for username and register > username_element to gatekeeper, which manages revealing > the input suggested value to JS after user action. > > Along the way, a small improvement was implemented, setting > the username value only in one place which simplifies the code. > > Bug: 798492 > Change-Id: Ib37637dd861f44b94674c6d0060ebc91dfd73cff > Reviewed-on: https://chromium-review.googlesource.com/850394 > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527598} TBR=battre@chromium.org,dvadym@chromium.org Change-Id: I53dba03674f0fa93f077f51dd481d951f8036825 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798492 Reviewed-on: https://chromium-review.googlesource.com/852501 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#527627}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .