commit	c463a13bdfe19a4112e14276760e707e0e7d007e	[log] [tgz]
author	Tom Anderson <thomasanderson@chromium.org>	Wed Aug 15 02:47:05 2018
committer	Commit Bot <commit-bot@chromium.org>	Wed Aug 15 02:47:05 2018
tree	a359abdef90320f3a9ca769ec243b13eeefdcf8c
parent	1de54d4ef4f143e74fbae9286ea3f16480b2f4d3 [diff]

Repurpose the confirm-quit-bubble to a quit-instruction-bubble

It was decided in [1] that the Ctrl+Shift+Q shortcut should be removed
altogether and replaced with a bubble giving an alternative way to quit using
the keyboard (similar to the "Press Alt+Left to go back" bubble).

[1] https://docs.google.com/document/d/1mvTBrxD58GIsqFiqgiLCZiXy1iOtDpQx_Tp5OSuYWEU/edit?usp=sharing

BUG=243164
R=sky

Change-Id: I47578d6b750c45fbc5d0a6e6ffe7e5f528dbe80d
Reviewed-on: https://chromium-review.googlesource.com/1173654
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583138}

chrome/app/chrome_command_ids.h[diff]
chrome/app/generated_resources.grd[diff]
chrome/browser/about_flags.cc[diff]
chrome/browser/flag_descriptions.cc[diff]
chrome/browser/flag_descriptions.h[diff]
chrome/browser/lifetime/browser_shutdown_browsertest.cc[diff]
chrome/browser/ui/BUILD.gn[diff]
chrome/browser/ui/browser_command_controller.cc[diff]
chrome/browser/ui/toolbar/app_menu_model.cc[diff]
chrome/browser/ui/views/accelerator_table.cc[diff]
chrome/browser/ui/views/confirm_quit_bubble_base.h[Deleted - diff]
chrome/browser/ui/views/confirm_quit_bubble_controller.cc[Deleted - diff]
chrome/browser/ui/views/confirm_quit_bubble_controller.h[Deleted - diff]
chrome/browser/ui/views/confirm_quit_bubble_controller_unittest.cc[Deleted - diff]
chrome/browser/ui/views/frame/browser_view.cc[diff]
chrome/browser/ui/views/quit_instruction_bubble.cc[Renamed from chrome/browser/ui/views/confirm_quit_bubble.cc - diff]
chrome/browser/ui/views/quit_instruction_bubble.h[Renamed from chrome/browser/ui/views/confirm_quit_bubble.h - diff]
chrome/browser/ui/views/quit_instruction_bubble_base.h[Added - diff]
chrome/browser/ui/views/quit_instruction_bubble_controller.cc[Added - diff]
chrome/browser/ui/views/quit_instruction_bubble_controller.h[Added - diff]
chrome/browser/ui/views/quit_instruction_bubble_controller_unittest.cc[Added - diff]
chrome/common/chrome_features.cc[diff]
chrome/common/chrome_features.h[diff]
chrome/test/BUILD.gn[diff]
tools/metrics/histograms/enums.xml[diff]
ui/strings/ui_strings.grd[diff]

26 files changed

tree: a359abdef90320f3a9ca769ec243b13eeefdcf8c

README.md

Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .