commit | c56690c375a47ba4822e689acb3f6998c96791f9 | [log] [tgz] |
---|---|---|
author | Yuta Kitamura <yutak@chromium.org> | Mon Oct 22 10:52:12 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 22 10:52:12 2018 |
tree | f2450a0f7f4f52ed4e9ed65e87c6e15e59821cca | |
parent | 32463438c420d2887617acec90ec57b4946b8884 [diff] |
Merge WebThreadBase into Thread. This CL melds WebThreadBase's implementation into Thread, and removes WebThreadBase. Now WebThreadImpl* classes directly inherit from Thread. This is part of WebThread refactoring effort. The new implementation uses WTF::HashMap instead of std::map to store the mapping of TaskObservers. TaskObserverAdapters are stored in std::unique_ptr, so we don't need manual new/delete calls. Eventually, we will migrate to base::MessageLoop::TaskObserver instead of Blink's custom TaskObserver, which would eliminate this mapping object. Thread::IsCurrentThread() is now implemented in terms of its thread- local storage for Blink threads, just because we already have that knowledge ourselves. Also, {Add,Remove}Task{,Time}Observer() are simplified. Now the internal versions of those functions are removed, and TaskObserver functions are now non-virtual. Bug: 826203 Change-Id: I5aa56c152543af8f0e0270db86aa0f51d619b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/1283015 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#601521}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .