commit | c5acaed0a846e3dba26d30fa9fa3cd0b745b4700 | [log] [tgz] |
---|---|---|
author | Justin Suen <justinsuen@google.com> | Tue Dec 01 21:23:38 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 01 21:23:38 2020 |
tree | 482871ac3ef7c44aff96844a18ef9e272f496488 | |
parent | 3828a0a25a5cd9f5cf9a4473474d0b35e97b92eb [diff] |
Manual Repair: update ListManualRepairRecords params Add user ldap and repair state and filterable params to ListManualRepairRecords rpc. Add validator for validating rpc request object as well. BUG=chromium:1130823 TEST=make test; make dev Change-Id: I78102c705d6ce5d3cf3594a2ad256afbe4629d25 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2556488 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Justin Suen <justinsuen@google.com> Cr-Commit-Position: refs/heads/master@{#36804}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.