Google Git
Sign in
chromium / chromium / src / c7586428da170b5323c25305dd3e213c38c6aa41
commitc7586428da170b5323c25305dd3e213c38c6aa41[log] [tgz]
authorMario Sanchez Prada <mario@igalia.com>Fri Nov 09 17:58:16 2018
committerCommit Bot <commit-bot@chromium.org>Fri Nov 09 17:58:16 2018
treee06174ae2be4ffc05fea69ba6f56aeadb73ec229
parent8c3cd622f0bc02e3b9744194b5ff8e7410d26a27 [diff]
Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager

Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually
creating the browser's state by providing specific factories, and then
use the APIs from IdentityTestEnvironment, instead of SigninManagerBase.

Also remove an unnecessary DCHECK in clear_browsing_data_manager_unittest.mm,
as pointed out post-review when fixing crbug.com/890826 (CL 1318974).

Bug: 903703
Change-Id: I9d4dd625441005a36c962628fe3fe1f15ab56bb6
Reviewed-on: https://chromium-review.googlesource.com/c/1328985
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#606894}
3 files changed
tree: e06174ae2be4ffc05fea69ba6f56aeadb73ec229
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .