| commit | c7cde6acb654b2c9cef527c0e8ac262d480c9f06 | [log] [tgz] |
|---|---|---|
| author | brettw <brettw@chromium.org> | Wed Nov 25 22:24:44 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Nov 25 22:25:43 2015 |
| tree | 1732b7fd0e4832ea9b5e122b80dd74e45e50a6d0 | |
| parent | d4bd2aafb9eb736fa1cf3844cb389c30d91aa7db [diff] |
Revert of New build flag system, convert Google Now flag (patchset #2 id:20001 of https://codereview.chromium.org/1475513006/ ) Reason for revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/69779/steps/compile/logs/stdio Original issue's description: > New build flag system, convert Google Now flag > > This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included. > > Converts Google Now to use this and remove the global google now define and grit define. > > Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False"). > > Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency. > > Reland of https://codereview.chromium.org/1458653002/ > TBR=mark@chromium.org > > Committed: https://crrev.com/cbc1cd295bc85219ad89326457cd7f5cf003d41c > Cr-Commit-Position: refs/heads/master@{#361741} TBR=mark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1480693003 Cr-Commit-Position: refs/heads/master@{#361749}