commit | c7fda54ed0b151331e08730c45040976adf7cad7 | [log] [tgz] |
---|---|---|
author | Thiemo Nagel <tnagel@chromium.org> | Tue Jan 08 17:20:36 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 08 17:20:36 2019 |
tree | 50bbc2ef8aff4cf439d9426b5e69a6ecab096e38 | |
parent | e0bde7a1178e3367df87ebcbe0928c61b249072c [diff] |
Revert "viz: Cleanup callback types." This reverts commit 7462bc1cab4bc11c76ba65d10ea56f9378484d40. Reason for revert: suspicion of breaking video.WebRTCCamera on chromeos-amd64-generic-rel (sorry in advance if I'm wrong) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel/24062 2019/01/08 07:41:36 Running video.WebRTCCamera 2019/01/08 07:41:36 Restarting ui job 2019/01/08 07:41:41 Clearing device owner info 2019/01/08 07:41:41 Waiting for org.chromium.SessionManager D-Bus service 2019/01/08 07:41:41 Asking session_manager to enable Chrome testing 2019/01/08 07:41:41 Waiting for Chrome to write its debugging port to /home/chronos/DevToolsActivePort 2019/01/08 07:41:42 Removing cryptohome for testuser@gmail.com 2019/01/08 07:41:42 Finding OOBE DevTools target 2019/01/08 07:41:43 Connecting to Chrome at ws://127.0.0.1:41481/devtools/page/E3AE03DCDCE497A47AFDB8CA52CBE579 2019/01/08 07:41:43 Waiting for OOBE 2019/01/08 07:41:50 Logging in as user "testuser@gmail.com" 2019/01/08 07:41:51 Waiting for cryptohome for user "testuser@gmail.com" 2019/01/08 07:41:59 Waiting for OOBE to be dismissed 2019/01/08 07:42:04 Creating new page with URL http://127.0.0.1:39539/getusermedia.html 2019/01/08 07:42:04 Connecting to Chrome at ws://127.0.0.1:41481/devtools/page/4C1188A054BDBE0276A3DF2A6B7B1A22 2019/01/08 07:42:12 Results: [{Width:640 Height:480 FrameStats:{TotalFrames:0 BlackFrames:0 FrozenFrames:0} Errors:[]} {Width:1280 Height:720 FrameStats:{TotalFrames:25 BlackFrames:0 FrozenFrames:0} Errors:[]}] 2019/01/08 07:42:12 Error: [webrtc.go:206] 640x480 was not healthy: no frame was displayed 2019/01/08 07:42:12 Finished video.WebRTCCamera Original change's description: > viz: Cleanup callback types. > > Remove usage of deprecated base::Bind, base::Callback, base::Closure and > base::CancelableClosure types from components/viz/*. Where possible > convert to the corresponding once type. Otherwise replace with the > repeating type which is equivalent to the deprecated type. > > Bug: 714018 > Change-Id: I4cb59d4eb63f49662fa50c758617f71f017103a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1398789 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620717} TBR=danakj@chromium.org,kylechar@chromium.org Change-Id: I327c747bce826c932e255e50f58c3fb59a01e946 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/1401064 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#620771}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .