commit | c875e5d1fa83c83cf8cf3258454717c3b740e8b6 | [log] [tgz] |
---|---|---|
author | arthursonzogni <arthursonzogni@chromium.org> | Tue May 22 15:16:02 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 22 15:16:02 2018 |
tree | 666cf4a226e3bb8b71a293eef55775224befffab | |
parent | 6139e2e6a42b79b4b17f5b0e18588b19dcb1b347 [diff] |
navigate_to_204.html: Wait for window.load before navigating. I am working on https://crbug.com/831155. Some tests that are relying on how things are scheduled in Blink are failing. This CL makes the following test to keep working: * ExecuteScriptApiTest.FrameWithHttp204 What happened with this test? 1) Javascript test is started: test/data/extensions/api_test/executescript/http204/background.js 2) Function navigateToFrameAndWaitUntil204Loaded is executed. It navigates to: /extensions/api_test/executescript/http204/navigate_to_204.html?b.com 3) |location.href = "[...]page204.html"| happens before the document is fully loaded. 4) The navigation to page204.html cancels the previous one. FrameMsg_DroppedNavigation IPC is sent. 5) Test fails, it expected "page204.html" load to fail, but "navigate_to_204.html" failed first. Solution is to wait for the document to be fully loaded before navigating to page204.html. Bug: 831155 Change-Id: I8780a48877a8a6a67338aa4a1ae167952cb35fb8 Reviewed-on: https://chromium-review.googlesource.com/1065972 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#560592}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .