commit | ca26bdcbedb22974f571ac6523fcf9603c34cb8b | [log] [tgz] |
---|---|---|
author | Garrett Beaty <gbeaty@chromium.org> | Tue Nov 10 16:16:42 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 10 16:16:42 2020 |
tree | d06e82bc2030bf06cb1e26a62d38eaf1e92e4116 | |
parent | 10b274b1e70a14ea1793ec6147e88c0780909b56 [diff] |
Revert "Configure the chromium_android module for all android builders." This reverts commit 10b274b1e70a14ea1793ec6147e88c0780909b56. Reason for revert: Does not address problem: builder crashes later: https://ci.chromium.org/p/chromium/builders/ci/android-paeverywhere-arm-fyi-dbg/83 Original change's description: > Configure the chromium_android module for all android builders. > > Curently, if an android builder does not specify an android config, it > ends up causing an infra failure when it attempts to run > chromium_android module code because the module has not been configured. > With this change, the same condition gates whether to configure the > chromium_android module and whether to call its code. It is not > necessary to explicitly set the android config in a bot spec because the > module has a root config which sets necessary values. The majority of > configs for the module do not have any effect and should be cleaned up. > > Change-Id: I8afb7278173a253abc2bbeeeeee496a88f0fd74b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2525788 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> TBR=bpastene@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I44cec5b74b88beb0d9802f2989e5e23c3f4a19ac No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2529592 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.