| commit | cab0f2e9bc64a1caf21877b36972a30212c685e6 | [log] [tgz] |
|---|---|---|
| author | gcasto <gcasto@chromium.org> | Fri Sep 23 23:16:05 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Sep 23 23:19:07 2016 |
| tree | 78d8ddad75d03b0da8953652fd538fe610f3ce9b | |
| parent | f507a4425364347073fa5e07fd90d8b2ba6084c5 [diff] |
Revert of Handling new frames and frame navigations with find-in-page during a find session. (patchset #2 id:120001 of https://codereview.chromium.org/2236403004/ ) Reason for revert: This seems to be failing pretty consistently on some bots (e.g. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29) Original issue's description: > Handling new frames and frame navigations with find-in-page during a find session. > > This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar. > > Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates). > > Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view > > BUG=2220,621660 > > Committed: https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1 > Cr-Commit-Position: refs/heads/master@{#420715} TBR=dcheng@chromium.org,pkasting@chromium.org,kenrb@chromium.org,paulmeyer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=2220,621660 Review-Url: https://codereview.chromium.org/2363993003 Cr-Commit-Position: refs/heads/master@{#420774}