commit | cb3a154c9918e4a20ff3514d4c988e7c0392b5a1 | [log] [tgz] |
---|---|---|
author | Congbin Guo <guocb@chromium.org> | Wed Apr 07 00:14:08 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 07 00:14:08 2021 |
tree | ff361b8d859a5af9dce7c33e2bb728319c65e2db | |
parent | dd7dbb03896115dccc41496b3e132f8de0131378 [diff] |
tlw: decouple Session and TLW server When add more arguments to the constructor of TLW server, we also need to change the Session server implementation and unit tests due to the coupling between them. This patch breaks the coupling by defining a wiring server interface. We also define a builder interface so we can build fake TLW in unit tests. BUG=None TEST= 1) go test; 2) Ran an TLS/TLW integration test. Change-Id: I6e8fdac9e2e12909a6ade2a62cc87e622fa59529 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2807188 Auto-Submit: Congbin Guo <guocb@chromium.org> Commit-Queue: Congbin Guo <guocb@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Cr-Commit-Position: refs/heads/master@{#39963}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.