| commit | cbf0204555fe07fda96d20456e03f105e2922005 | [log] [tgz] |
|---|---|---|
| author | Vadim Bendebury <vbendeb@chromium.org> | Tue May 15 00:46:15 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue May 15 14:41:04 2018 |
| tree | 4fad48a840c422f91a7200d96c066a502ba0ac4e | |
| parent | babd098f3684f1bc965a0f72f96cb701eec91e52 [diff] |
do not try collecting issues information for an empty issues list
There is no point in trying to retrieve issues information when the
issues list is empty, On top of that the attempt to start a thread
pool with zero threads generates an exception.
TEST=running my_activity.py when the user does not have issues on
certain servers does not cause the exception any more.
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Change-Id: Ib5889a4c3390a01860fb31a4ff1a343e05b24051
Reviewed-on: https://chromium-review.googlesource.com/1058679
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.