commit | cd06095126c399079dde1743adf21462c05a471e | [log] [tgz] |
---|---|---|
author | Scott Violet <sky@chromium.org> | Wed Aug 15 15:55:32 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Aug 15 15:55:32 2018 |
tree | 7fe938b5901623d3cc68e65adfc636ca59c7e5ee | |
parent | 9753fedbda50a7e0ee8d4b7baa43d2f3bc9e24b8 [diff] |
reland: chromeos: gets more ash_unittests working with single-process mash The OverviewButtonTrayTests need to set the keyboard devices *after* AshTestBase::SetUp() is called. This is is important in single-process mash as Ash is the one creating the Env that the keyboard devices us. In non-single-process-mash AshTestSuite is creating the Env these tests use. The case ShellTest2.DontCrashWhenWindowDeleted is exercising is different enough for single-process mash that I created a separate test. Adding NOPRESUBMIT=true as this bot passed the trybots, and we're ok with this test including Env::GetInstance(). NOPRESUBMIT=true BUG=847992 TEST=test only changes TBR=jamescook@chromium.org Change-Id: I46fbfa9c78e8b28ac459b9863e34f3761a077c9a Reviewed-on: https://chromium-review.googlesource.com/1175848 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583262}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .