commit | cd24bd88f1eed423ee5ccf01e59da89fa38b781c | [log] [tgz] |
---|---|---|
author | Devlin Cronin <rdevlin.cronin@chromium.org> | Fri Dec 14 03:36:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 14 03:36:08 2018 |
tree | 3f4e46364fb3729098b3fef59e7e92718110e17c | |
parent | 4e935b3f1cba49f5ed550a031942aea34cadaba8 [diff] |
[Extensions] Don't allow overwriting ManifestHandlers Currently, ManifestHandler::Register() and ManifestHandlerRegistry::RegisterManifestHandler() allow registering a new ManifestHandler with a key that has already been associated with another ManifestHandler, overwriting the current entry. Remove this behavior, and make ManifestHandlerRegistry DCHECK if a handler is registered with an already-associated key. This is for a few reasons: - We never actually overwrite keys currently - If we did overwrite a key, it would likely be a bug - It's conceptually simpler - It will make removing linked_ptrs from ManifestHandlerRegistry simpler. Bug: 914401 Change-Id: Ie15e9598cc65b8ce3c6b95a666addb41e54d8e0d Reviewed-on: https://chromium-review.googlesource.com/c/1374115 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#616576}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .