commit | cd3e5fb1f8d2b4106dc5e1805ad8c8108f08fc83 | [log] [tgz] |
---|---|---|
author | Robert Flack <flackr@chromium.org> | Sat Nov 10 00:15:13 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Nov 10 00:15:13 2018 |
tree | 403cdb6cb033b2c6c0449a2d30d045981279036b | |
parent | 47b8dc1d746cd4ebc2d725ab24891553602bfeaf [diff] |
Revert "Drag and Drop: Frames not containing drag source shouldn't be able to reset drag state" This reverts commit df72f9b57cbf37f32f291add8a6f658068924a9a. Reason for revert: This caused a memory leak detected by the WebKit Linux Trusty Leak bot: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/ Original change's description: > Drag and Drop: Frames not containing drag source shouldn't be able to reset drag state > > Only allow frames who are ancestors of the drag_src_ to reset a drag_src_ > > Created layout test to show previous lack of dragend when moving iframe in dom as a result of dragging > Created layout test to verify lack of regression when frames containing drag source are moved/detached > > Bug: 737691 > Change-Id: Ic6cc8ac0528d35ac93a21612b453d6b3203a152d > Reviewed-on: https://chromium-review.googlesource.com/c/1265818 > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606276} TBR=dcheng@chromium.org,pwnall@chromium.org,huangdarwin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 737691 Change-Id: I560230c44bbcc055632abcd81b3d6286f972f530 Reviewed-on: https://chromium-review.googlesource.com/c/1330329 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607044}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .