Google Git
Sign in
chromium / chromium / src / cdd220e8b290495f6ae89d83ad66581e100ef1e7
commitcdd220e8b290495f6ae89d83ad66581e100ef1e7[log] [tgz]
authorPeter Boström <pbos@chromium.org>Tue Jan 23 16:48:08 2018
committerCommit Bot <commit-bot@chromium.org>Tue Jan 23 16:48:08 2018
tree98148a521355896f0d668de7fc4b56730aab2edf
parentb97b12c30c11f0639219c6f4eb7a54b7b62909fd [diff]
Break out the password PendingView dialog.

Makes ManagePasswordPendingView a stand-alone dialog and reimplements
buttons using the DialogClientView infrastructure, which enables correct
OK/Cancel button ordering per OS. This is done both for the main dialog
and the promo dialogs it contains (including the iOS promotion dialog as
triggered by the bookmarks view).

The dialogs have not yet been styled for Harmony apart from fixing
button ordering.

Bug: chromium:654115
Change-Id: I8c775de0b317125297d8b2caf415052778c2e0e3
Reviewed-on: https://chromium-review.googlesource.com/872096
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531259}
12 files changed
tree: 98148a521355896f0d668de7fc4b56730aab2edf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .