Google Git
Sign in
chromium / chromium / src / ce42ef44c3eed5f149698aac79c9619d2decbace
commitce42ef44c3eed5f149698aac79c9619d2decbace[log] [tgz]
authorFrancois Doray <fdoray@chromium.org>Thu Sep 14 15:24:20 2017
committerCommit Bot <commit-bot@chromium.org>Thu Sep 14 15:24:20 2017
treef2cd52a81c3ab8a88da5821b0e66b82fc81eafee
parent25610144a23efc46424e7dc97730926ca3fc9d70 [diff]
Remove the usage of BrowserThread::FILE in the spellchecker files

Previously landed as
https://chromium-review.googlesource.com/c/chromium/src/+/619607

Relanding with RunAllBlockingPoolTasksUntilIdle() in browser test.

The usage of BrowserThread::FILE is deprecated in favor of the
post_task.h API.

This is a new attempt at
https://chromium-review.googlesource.com/c/510018,
that got reverted because of flaky tests.

I changed the code to make sure the dictionary is deleted on the
same task runner is it used in.

TBR=rouslan@chromium.org

Bug: 689520
Change-Id: Ib0b0d39dbdd0f0f7625baab65fcfe3e0a28306e0
Reviewed-on: https://chromium-review.googlesource.com/667239
Reviewed-by: Francois Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501955}
5 files changed
tree: f2cd52a81c3ab8a88da5821b0e66b82fc81eafee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .