Google Git
Sign in
chromium / chromium / src / cfc362075decc975920c8c820967bcd612ee2a13
commitcfc362075decc975920c8c820967bcd612ee2a13[log] [tgz]
authorAleks Totic <atotic@chromium.org>Thu Jun 28 23:15:19 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jun 28 23:15:19 2018
tree62c6038ac7c2424cc9d9466042574259492c7db0
parentdf9afcca2f5e11e556f01b626ac820fde76c58ce [diff]
[LayoutNG] Fix abspos percentage margins

Margins were being computed incorrectly in abspos_utils.
Margins were not being copied to Legacy.

The tricky part is that if node is using old block layout,
strange margins get computed because of the way we enforce
abspos child size:
SetIsFixedSizeInline
causes block layout to compute margins wrt that fixed size.

The fix is to let Legacy block layout compute margins
incorrectly, and set them to correct values afterwards.

Bug: 740993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6e9354fdcad0e0703bd35ad849300be9f223f618
Reviewed-on: https://chromium-review.googlesource.com/1119078
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571318}
5 files changed
tree: 62c6038ac7c2424cc9d9466042574259492c7db0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .