commit | d0b30b2fe3396d4ca76e348f0a39ea74a8ad2b98 | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Wed Jan 09 14:00:37 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 09 14:00:37 2019 |
tree | 9d5c8b6c2bacb344308faa2a6aefd5db6697dd58 | |
parent | 6d84ca364940f36d43cdd29b51dc968a3d92d9f2 [diff] |
sync_integration_tests: don't instantiate ScopedFeatureList in test body Creating a ScopedFeatureList instance in the test body creates a data race related to the global FeatureList instance: The ScopedFeatureList overrides the global instance, and then it gets reset after the test body; however, the feature list might still be queried from the Sync thread after that. This CL avoids the issue by instead creating test (sub)classes to hold the ScopedFeatureLists. Bug: 915219 Change-Id: Ib1e0d87ed4ecc5ef33e9601ba84efecd399fb003 Reviewed-on: https://chromium-review.googlesource.com/c/1402799 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#621134}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .