commit | d12d293f7c958cd389bb29d5bd1f6f3c274a7799 | [log] [tgz] |
---|---|---|
author | Adithya Srinivasan <adithyas@chromium.org> | Wed Dec 26 06:20:53 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 26 06:20:53 2018 |
tree | 871e6465dd0132ad4edea66d3efe21fde45fa792 | |
parent | 0213c55a58f27c9b9541c2a01987e722a0e2063f [diff] |
[WebMIDI] Detach clients in MidiService::Shutdown MidiService::Shutdown clears the |manager_| pointer but doesn't directly destroy MidiManager. Clients cannot call EndSession and remove themselves from the |clients_| list in MidiManager (because MidiService no longer owns it). These clients then can be independently destroyed, leading to a use after free when MidiManager tries to call Detach on the clients. Bug: 915693, 913270, 582328 Change-Id: I0f713743bfd8f736c17e3ec3dd8472bd05ad7254 Reviewed-on: https://chromium-review.googlesource.com/c/1383436 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#618906}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .