commit | d13e90544ecc6da9fb394c5c61e927c0fe03ec65 | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Tue Jun 25 21:05:36 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jun 25 21:05:36 2019 |
tree | ea5f5f3df4edfb4440a697c809b07eac5521b584 | |
parent | 0119d8e52f84da34f5c823a4f0ee2ce71a3ebe6a [diff] |
[step_runner/subproc] Fix obvious regression from previous CL. The timeout case is triggering when we DIDN'T time out, and is skipped in the actual timeout case. TBR=tandrii@chromium.org Bug: 978532,910369 Change-Id: I81161be5238974e6cb844cfb0948c63f6e015344 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1676841 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email
and user.name
are configured in git config
.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help
and git cl help <cmd>
for more details.