commit | d1e2a7bcbc4d1eec42bfdfac1116c8aba2e58411 | [log] [tgz] |
---|---|---|
author | Tessa Nijssen <tnijssen@google.com> | Fri Jul 20 20:42:09 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 20 20:42:09 2018 |
tree | ce0a03dda23d5f432474b4d9f1f243a9bd152d38 | |
parent | 72a7cfc50a1758503162b220b94ad4e850fe463a [diff] |
[Mac] Collapse NSCandidateListTouchBarItem if Text is Selected On Safari, when there is text selected and not just a cursor in text, the NSCandidateListTouchBarItem collapses. This change checks if the selection range has a non-zero length, and if it does, collapses the created NSCandidateListTouchBarItem. The text suggestions are still accessible by clicking on the collapsed NSTouchBarItem. A unit test, CollapsedCandidateListTest, was written to test that the NSTouchBarItem properly collapses according to the length of the selection range. Bug: 717553 Change-Id: I25671450f43b4ba14197f76e431f9212d5494187 Reviewed-on: https://chromium-review.googlesource.com/1144300 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576975}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .