Google Git
Sign in
chromium / chromium / tools / build / d21a35b7ddbcd389fc14dcb581eda8c130403945
commitd21a35b7ddbcd389fc14dcb581eda8c130403945[log] [tgz]
authorMichael Achenbach <machenbach@chromium.org>Fri Aug 07 10:12:12 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 07 10:12:12 2020
tree467be425423fdacd99c2269ca9535211710ba13a
parentbcda5c6e6eca19891cf272a9479c1c27ea3b8c37 [diff]
[V8] Enable setting custom gclient variables

This generalizes the recipe parameter set_gclient_var to a new
parameter gclient_vars for setting several custom gclient variables
with custom values. The previous property was only setting value
'True'. Now we can set arbitrary values as needed for setting the
mac toolchain.

We'll remove the old property after switching cr-buildbucket.cfg to
the new one.

Bug: 1110824
Change-Id: Ieecdf49a08020c6f0f60f9d935cfa26adaf8ed40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2339328
Reviewed-by: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
2 files changed
tree: 467be425423fdacd99c2269ca9535211710ba13a
  1. infra/
  2. scripts/
  3. site_config/
  4. third_party/
  5. .gitattributes
  6. .gitignore
  7. .style.yapf
  8. .vpython
  9. .yapfignore
  10. codereview.settings
  11. CROS_OWNERS
  12. DEPS
  13. environment.cfg.py
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. WATCHLISTS
README.md

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format) to autoformat new code.