commit | d249c7c85a44b6b5cb6084d3a9ec18a35d8e9539 | [log] [tgz] |
---|---|---|
author | Koji Ishii <kojii@chromium.org> | Mon Jul 30 05:30:04 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 30 05:30:04 2018 |
tree | b6deae6e94be40429891696d1447f2ba4ab68f30 | |
parent | 60b9c2fffb00aabd81da961035c22e381c64659e [diff] |
[LayoutNG] LayoutInline/LayoutText unites rects if not zero This patch uses UniteIfNotZero, which incorporates rects if either width *or* height is not zero, to compute LinesBoundingBox for LayoutInline and LayoutText. Using regular Unite, which incorporates rects if width *and* height are not zero, ignores zero-width rects such as empty inline or <br>. The name and logic are ported from LayoutRect to NGPhysicalOffsetRect. This patch fixes two tests, but also require ~300 text rebaselines because heights of such LayoutInline, LayoutText, and their subclasses (such as <br>) are changed. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6488c074dedad71ae5f46fb366ee4a2b9d3cdca5 Reviewed-on: https://chromium-review.googlesource.com/1154240 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578980}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .